Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix properties with incorrect types #173

Merged
merged 6 commits into from
Nov 4, 2024
Merged

Fix properties with incorrect types #173

merged 6 commits into from
Nov 4, 2024

Conversation

rvazarkar
Copy link
Contributor

@rvazarkar rvazarkar commented Oct 21, 2024

Description

Several properties being collected currently are collected as strings instead of as integers or other value types. This MR corrects this

Additionally, elevates some try/catch blocks to fix some unhandled exceptions around principalcontext checks

Motivation and Context

https://specterops.atlassian.net/browse/BED-4928
BloodHoundAD/SharpHound#120

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

@rvazarkar rvazarkar changed the title Fix properties in incorrect types Fix properties with incorrect types Oct 22, 2024
@rvazarkar rvazarkar merged commit 9e03f0c into v4 Nov 4, 2024
3 checks passed
@rvazarkar rvazarkar deleted the BED-4928 branch November 4, 2024 14:52
@github-actions github-actions bot locked and limited conversation to collaborators Nov 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants